Align y-axes in mmm.plot.budget_allocation #1967
Draft
+37
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1967 +/- ##
==========================================
- Coverage 92.18% 91.94% -0.24%
==========================================
Files 67 67
Lines 8147 8169 +22
==========================================
+ Hits 7510 7511 +1
- Misses 637 658 +21 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
still needs tests to go through the combinations of negative positive and ensure that the axis limits are correct after the call. |
Comment on lines
+248
to
+274
| if ax.axes.get_ylim()[0] < 0 or ax2.axes.get_ylim()[0] < 0: | ||
| ylims1 = ax.axes.get_ylim() | ||
| ylims2 = ax2.axes.get_ylim() | ||
| # Find the ratio of negative vs. positive part of the axes. | ||
| if ylims1[1]: | ||
| ax1_yratio = ylims1[0] / ylims1[1] | ||
| else: | ||
| # Fully negative axis. | ||
| ax1_yratio = -1 | ||
|
|
||
| if ylims2[1]: | ||
| ax2_yratio = ylims2[0] / ylims2[1] | ||
| else: | ||
| # Fully negative axis, may need to reflect the other | ||
| ax2_yratio = -1 | ||
|
|
||
| # Make axis adjustments. If both axes fully negative, no adjustment. | ||
| if ax1_yratio < ax2_yratio: | ||
| ax2.set_ylim(bottom=ylims2[1] * ax1_yratio) | ||
| if ax1_yratio == -1: | ||
| # if the axis is fully negative, center zero. | ||
| ax.set_ylim(top=-ylims1[0]) | ||
| elif ax2_yratio < ax1_yratio: | ||
| ax.set_ylim(bottom=ylims1[1] * ax2_yratio) | ||
| if ax2_yratio == -1: | ||
| # if the axis is fully negative, center zero. | ||
| ax2.set_ylim(top=-ylims2[0]) |
There was a problem hiding this comment.
Can you use NamedTuple or something. Quite confusing to read
There was a problem hiding this comment.
Looking at this now, I fully agree. I also think that this is not capturing every possible combination the axes can get odd. I'll move this to a draft and rework it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ensure that y=0 is aligned between the primary and secondary y-axis in
mmm.plot.budget_allocation.Solution
If one axis includes negative, values the other is extended down so that the y=0 is aligned.
If all contributions would be fully negative (I don't know when this would happen...), the y=0 level is centered vertically on both axes.
Related Issue
Checklist
pre-commit.ci autofixto auto-fix.📚 Documentation preview 📚: https://pymc-marketing--1967.org.readthedocs.build/en/1967/